Add support for bools in SimpleImputer #31730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Could you please parametrise the dataframe tests and make sure things work as well for polars?
@Charlie-XIAO I wonder if there's a cleaner way to implement this?
| @@ -0,0 +1,3 @@ | |||
| :class:`impute.SimpleImputer` now supports boolean data types for | |||
| NumPy arrays and pandas DataFrames. | |||
| By :user:`[Ritvi Alagusankar] <ritvi-alaguankar>`. | |||
There was a problem hiding this comment.
Suggested change
| By :user:`[Ritvi Alagusankar] <ritvi-alaguankar>`. | |
| By :user:`Ritvi Alagusankar <ritvi-alaguankar>`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #26292
Changes in PR:
_validate_inputto recognize boolean dtypes and set dtype to bool.