MAINT Clean up deprecations for 1.8: scoring='max_error' #31753
Conversation
There was a problem hiding this comment.
Thanks a lot @natmokval! 🚀
I think we can now fully remove the defined max_error_scorer in the _SCORERS dict.
Apart from that little thing, I think that clean-up is fine and complete.
sklearn/metrics/_scorer.py
Outdated
| @@ -735,13 +722,6 @@ def make_scorer( | |||
| r2_scorer = make_scorer(r2_score) | |||
| neg_max_error_scorer = make_scorer(max_error, greater_is_better=False) | |||
| max_error_scorer = make_scorer(max_error, greater_is_better=False) | |||
There was a problem hiding this comment.
I think we can remove the defined max_error_scorer (from currently line 724) as well.
It is not not used anywhere anymore.
There was a problem hiding this comment.
I’ve now removed the max_error_scorer as you suggested (currently line 724). Thanks for your help!
Thanks @StefanieSenger for reviewing this PR. I couldn’t find |
There was a problem hiding this comment.
That looks very good. Thanks again, @natmokval! Approving.
Would you be so kind to help me with understanding something? I wonder which AI tool you were using and how it worked to produce this comment:
Thanks @StefanieSenger for reviewing this PR. I couldn’t find max_error_scorer in the _SCORERS dictionary — it looks like it was removed during deprecation.
Since you have just removed max_error_scorer from the _SCORERS dict with your last commit 89a8cf, it obviously was there and had not already been removed with the deprecation. Therefore, I find this comment confusing.
When in the process was it produced and by which tool? Thanks for your help.
Towards #29462
removed deprecated (renamed to
neg_max_error) scoring=max_error