CI Avoid miniconda CondaToSNonInteractiveError #31771

lesteve · 2025-07-16T07:43:49Z

This is currently breaking all the PRs with the error (from build log):

+ conda create --name testvenv --file ./build_tools/azure/pylatest_conda_forge_mkl_linux-64_conda.lock

CondaToSNonInteractiveError: Terms of Service have not been accepted for the following channels. Please accept or remove them before proceeding:
    • https://repo.anaconda.com/pkgs/main
    • https://repo.anaconda.com/pkgs/r

To accept a channel's Terms of Service, run the following and replace `CHANNEL` with the channel name/URL:
    ‣ conda tos accept --override-channels --channel CHANNEL

To remove channels with rejected Terms of Service, run the following and replace `CHANNEL` with the channel name/URL:
    ‣ conda config --remove channels CHANNEL

Likely a conda change in the Azure image.

Close #31766, close #31767, close #31768, close #31769

Edit: and #31773

github-actions · 2025-07-16T07:45:02Z

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 1bd5850. Link to the linter CI: here}

jeremiedbb · 2025-07-16T08:45:42Z

build_tools/azure/windows.yml

+    - bash: echo "##vso[task.prependpath]$CONDA/Scripts"
+      displayName: Add conda to PATH
+      condition: startsWith(variables['DISTRIB'], 'conda')
+    - bash: build_tools/azure/install_setup_conda.sh
+      displayName: Install conda if necessary and set it up
+      condition: startsWith(variables['DISTRIB'], 'conda')


adding conda to PATH is also done in install_setup_conda.sh, so we probably don't need it anymore if we're using the script.

Wouldn't it make things simpler to put the accept tos command there ?

scikit-learn/build_tools/azure/install.sh

Lines 57 to 60 in fe6960b

python_environment_install_and_activate() {

if [[ "$DISTRIB" == "conda"* ]]; then

create_conda_environment_from_lock_file $VIRTUALENV $LOCK_FILE

activate_environment

It feels slightly more logical to fix it earlier than in install.sh because this seems related to tweaks that are needed only for the Azure-provided conda.

conda tos only exists for miniconda, sometimes we use miniforge (Azure doesn't have conda installed for macOS-13 and macOS-14).

It seemed too much work to make install_setup_conda.sh work on Windows. So I did a Windows-specific fix in windows.yml.

icfaust · 2025-07-16T09:08:25Z

Just as a heads up, Conda released a new ToS yesterday, and is tied to it (we faced similar problems in scikit-learn-intelex yesterday on azp) https://www.anaconda.com/legal/terms/terms-of-service would be worth reviewing generally before accepting (since it has implications on if scikit-learn is a non-profit or not).

icfaust · 2025-07-16T09:17:58Z

Our solution was to force everything over to conda-forge uxlfoundation/scikit-learn-intelex#2613

      (echo default_channels: & echo   - https://conda.anaconda.org/conda-forge) >> C:\Users\VssAdministrator\.condarc
      conda config --add channels conda-forge
      conda config --set channel_priority strict

which is a bit 'nuke from orbit', but then again the company I work for is in a legal dispute with anaconda.

jeremiedbb · 2025-07-16T09:23:23Z

If I understood correctly, there's no risk using conda, it has the same license as scikit-learn, very permissive (BSD 3-clause). The trouble might come from getting packages from the default channel. I don't know if scikit-learn satisfies the free-of-use conditions, so maybe it's time to stop installing any package from the default channel and install everything from the conda-forge channel.

…lel]

jeremiedbb · 2025-07-16T13:49:57Z

How does it interacts with update_environments_and_lock_files ? Shouldn't we remove the default channel there and regenerate the lock files ?

… [scipy-dev]

lesteve · 2025-07-16T14:32:11Z

Yes I wanted to make sure the install miniforge bash logic was working first. My last commit makes sure that we are only downloading packages from conda-forge.

Right now it seems that you get the ToS error only if you are using miniconda and not miniforge. Basically if conda (from miniconda) can figure out that you are using the defaults channel it will ask you to accept the ToS. Sometimes it doesn't figure it out like when creating an environment from a lock file where URLs are from the defaults channel ...

jeremiedbb · 2025-07-16T14:39:27Z

can figure out that you are using the defaults channel it will ask you to accept the ToS.

If I got it right, using it even if accepting the tos was not asked is implicitly considered accepted, so we better make sure to not use default in any case so that we don't have to worry about it at all :)

jeremiedbb

LGTM. Thanks !

jeremiedbb · 2025-07-16T15:13:13Z

I'm merging it with a single approval to unlock PRs and the release.

…ault channel (scikit-learn#31771)

betatim · 2025-07-17T06:03:26Z

I thought it was on purpose that we have some CI that uses the defaults channel for testing and not have 100% of our CI set up to use conda-forge. The motivation being that we have users who use defaults, so we should (sometimes) check things work. If that is still true, shouldn't we keep some defaults based CI?

I'm Ok with this change for now as it unlocks PRs and the release. With a bit more time we should consider the question of testing with defaults or not.

(Should I make a new issue for this?)

lesteve · 2025-07-17T07:23:59Z

Indeed there was some motivation to keep some CI builds defaults work because some of our users may use defaults. Honestly I am not sure this was worth it and the ToS thing may just be the last straw that breaks the camel's back ...

defaults and conda-forge have been using the same conda recipes for a while IIRC. I guess there could still be subtle differences, but I am not sure what they would be, suggestions more than welcome!
I don't recall a defaults specific issue that was caught by the CI, but of course I may have missed it ...
What I do remember is that every once in a while, the most recent version is not available in defaults and you need to use temporary work-arounds in the CI.
there is also the ToS thing, I would guess that we are OK downloading from defaults on an open-source project CI, but at the same time, open-source use case is not explicitly mentioned so 🤷.

For completeness, amongst the CI builds that were still using defaults before this PR:

two of them were only using Python from conda and the Python packages were installed with pip: scipy-dev and pylatest_pip_openblas_pandas.
the only build still using conda packages was the macOS no-OpenMP one.

betatim · 2025-07-17T07:35:40Z

From the overview you gave, in particular that of the only two jobs left using defaults one wasn't really using it, and the fact that I expect less and less people to use defaults because of the new(ly enforced?) license terms I'd also vote to drop defaults all together. (Add to this my personal bias that defaults has nothing to offer over conda-forge ...)

I had a vague memory that there was a particular kind of BLAS (Intel MKL?) that is only available via defaults. But I guess that is just some old memory.

dawnwages · 2025-07-17T13:18:43Z

Hey Team! Community & DevRel at Anaconda here. This has been escalated. We are figuring it out and this is not the intended consequence. Hold tight while I figure out why youre getting this message.

New TOS is supposed to provide clarity and allow for open source to do what it does best -- innovate freely.

Following the details for how it applies to PyTorch as well. Issue closed, but threads like these are not the intended consequence.

Give me a beat and Ill follow back up ASAP. Feel free to email me dwages@anaconda.com.

icfaust · 2025-07-17T13:38:36Z

@dawnwages is your comment about pytorch related to pytorch/pytorch#158370 ?

dawnwages · 2025-07-17T13:45:28Z

Yes @icfaust and any other failures in builds because of the new package. If you see it show up anywhere else we're fixing immediately.

It is incorrect and should not require any changes.

icfaust · 2025-07-17T15:15:37Z

@dawnwages It looks as though from this blog post: https://www.anaconda.com/blog/conda-anaconda-tos-plugin

That it means that use on CI systems (like azure pipelines) means implicit acceptance of the ToS, which may or may not be desired.

Sorry to have stirred this up in the first place, but wanted to put it here for full transparency.

dawnwages · 2025-07-17T16:23:59Z

You're totally right @icfaust and I really appreciate you bringing it up! This is important.

We did not intend to interrupt CI workflows. A fix is coming soon (between an hour and 24 based on cache and workflows).

You can set the CONDA_PLUGINS_AUTO_ACCEPT_TOS environment variable to "yes" to accept the Terms of Service automatically and that will help you right now. Feel free to reach out to community@anaconda.com or my email dwages@anaconda.com.

status page: https://anaconda.statuspage.io/

So sorry for the inconvenience. Bear with us, our open source community are important to us and we're hoping to improve clarity and convenience. A fix is coming soon.

DW

dawnwages · 2025-07-17T16:24:54Z

CI systems (like azure pipelines) means implicit acceptance of the ToS, which may or may not be desired.

Yes, implicit acceptance. New ToS began July 15, 2025.

Not implicit acceptance, just not required to make developer changes right now. We want to give people a chance to know that ToS acceptance required is coming and make changes to their environment variables to accept. Not everyone is tuned into their build logs.

lesteve added 2 commits July 16, 2025 09:42

CI Avoid miniconda CondaToSNonInteractiveError

6fac613

[azure parallel]

6ff9151

github-actions bot added the Build / CI label Jul 16, 2025

lesteve added 3 commits July 16, 2025 09:51

Windows fix [azure parallel]

80bac53

Windows fix [azure parallel]

77d2c4b

Windows fix [azure parallel]

fb1734a

jeremiedbb reviewed Jul 16, 2025

View reviewed changes

lesteve added 8 commits July 16, 2025 11:53

Simpler Windows-specific fix [azure parallel]

5dbbcb8

Always use miniforge

750b6c2

Use miniforge also on Windows [azure parallel]

74fc940

try with curl [azure parallel]

340aa5d

fix curl argument [azure parallel]

76f6861

right extension on Windows [azure parallel]

6190885

fix for Windows [azure parallel]

02681b5

attempt to use Windows installer in non-interactive mode [azure paral…

25c0eaf

…lel]

Always use conda-forge for lock files + minor tweaks [azure parallel]…

1fa9a9e

… [scipy-dev]

Fix lock-file name [scipy-dev] [azure parallel]

1bd5850

jeremiedbb approved these changes Jul 16, 2025

View reviewed changes

jeremiedbb merged commit f1229ff into scikit-learn:main Jul 16, 2025
37 checks passed

lesteve deleted the conda-tos branch July 16, 2025 15:16

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

7aa9f4f

…ault channel (scikit-learn#31771)

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

484c05a

…ault channel (scikit-learn#31771)

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

f17bf43

…ault channel (scikit-learn#31771)

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

f97fe77

…ault channel (scikit-learn#31771)

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

dcab3cd

…ault channel (scikit-learn#31771)

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 16, 2025

CI Avoid miniconda CondaToSNonInteractiveError and stop using the def…

ef2aff9

…ault channel (scikit-learn#31771)

jjerphan mentioned this pull request Jul 17, 2025

Anaconda new ToS causing CI failures #31773

Closed

	python_environment_install_and_activate() {
	if [[ "$DISTRIB" == "conda"* ]]; then
	create_conda_environment_from_lock_file $VIRTUALENV $LOCK_FILE
	activate_environment

Uh oh!

CI Avoid miniconda CondaToSNonInteractiveError #31771

CI Avoid miniconda CondaToSNonInteractiveError #31771

Conversation

lesteve commented Jul 16, 2025 • edited by lorentzenchr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ Linting Passed

Uh oh!

jeremiedbb Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

lesteve Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

icfaust commented Jul 16, 2025

Uh oh!

icfaust commented Jul 16, 2025

Uh oh!

jeremiedbb commented Jul 16, 2025

Uh oh!

jeremiedbb commented Jul 16, 2025

Uh oh!

lesteve commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremiedbb commented Jul 16, 2025

Uh oh!

jeremiedbb left a comment

Choose a reason for hiding this comment

Uh oh!

jeremiedbb commented Jul 16, 2025

Uh oh!

Uh oh!

betatim commented Jul 17, 2025

Uh oh!

lesteve commented Jul 17, 2025

Uh oh!

betatim commented Jul 17, 2025

Uh oh!

dawnwages commented Jul 17, 2025

Uh oh!

icfaust commented Jul 17, 2025

Uh oh!

dawnwages commented Jul 17, 2025

Uh oh!

icfaust commented Jul 17, 2025

Uh oh!

dawnwages commented Jul 17, 2025

Uh oh!

dawnwages commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lesteve commented Jul 16, 2025 •

edited by lorentzenchr

Loading

github-actions bot commented Jul 16, 2025 •

edited

Loading

lesteve commented Jul 16, 2025 •

edited

Loading

dawnwages commented Jul 17, 2025 •

edited

Loading