Skip to content

DOC update news for 1.7.1 #31780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Conversation

jeremiedbb
Copy link
Member

No description provided.

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label Jul 18, 2025
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a7437de. Link to the linter CI: here

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge?

@jeremiedbb
Copy link
Member Author

Yes please :)

@betatim betatim merged commit 6cd690b into scikit-learn:main Jul 18, 2025
43 checks passed
@betatim
Copy link
Member

betatim commented Jul 18, 2025

Maybe we can add "make a separate PR that updates the news" a to do item for the release checklist to avoid the problem of people getting the "you aren't on a stable version" banner after a release?

@jeremiedbb
Copy link
Member Author

add "make a separate PR that updates the news" a to do item for the release checklist

Not sure what you mean ? it's already an item in the checklist, see #31762 (comment)

jeremiedbb added a commit that referenced this pull request Jul 18, 2025
@betatim
Copy link
Member

betatim commented Jul 18, 2025

Ah, maybe the thing to add to it is that we need to do this quite soon after making the release to avoid people reporting that the website is broken

@jeremiedbb
Copy link
Member Author

Well it's a bit tricky and I don't know which step triggers the unwanted banner. The thing is that many steps are ordered, i.e. depend on a previous one, and some steps need to be executed only when we're sure that the release is ready and in a good state.

@betatim
Copy link
Member

betatim commented Jul 18, 2025

I think the problem starts when we update the contents of https://github.com/scikit-learn/scikit-learn.github.io/tree/main/1.7 but don't update the version.json in the /dev/ folder. Somehow the version switcher code can work out that what it is displaying on scikit-learn.org/stable is not a version that is listed as stable in version.json.

lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants