Skip to content

MNT Add tags to GaussianMixture array API and precise them for PCA #31784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

MNT Add tags to GaussianMixture array API and precise them for PCA #31784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2b80b
Add __sklearn_tags__ to GMM
lesteve Jul 18, 2025
f953556
Make array_api_tags more precise for PCA
lesteve Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sklearn/decomposition/_pca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,10 @@ def score(self, X, y=None):
def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.transformer_tags.preserves_dtype = ["float64", "float32"]
tags.array_api_support = True
tags.array_api_support = (
self.svd_solver in ["full", "randomized"]
and self.power_iteration_normalizer == "QR"
)
tags.input_tags.sparse = self.svd_solver in (
"auto",
"arpack",
Expand Down
7 changes: 7 additions & 0 deletions sklearn/mixture/_gaussian_mixture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,3 +992,10 @@ def aic(self, X):
The lower the better.
"""
return -2 * self.score(X) * X.shape[0] + 2 * self._n_parameters()

def __sklearn_tags__(self):
tags = super().__sklearn_tags__()
tags.array_api_support = (
self.init_params in ["random", "random_from_data"] and not self.warm_start
)
return tags