MNT Remove unused utils._array_api functions #31785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is slightly off-topic, but I was just wondering whether |
codecov on PRs checks the coverage of the diff. So when its usage was replaced by xp.isdtype, it was not touched and codecov didn't complain. I think it also check the global coverage and complains if we've less than some threshold, but a single uncovered small function can't make us pass under the threshold. |
|
Looking at the coverage of |
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem used anymore and we use
xp.isdtypeinstead.Looks like the
_array_api.isdtypewas added before we decided to vendor array-api-compat: #26029.