CI Use venv rather than virtualenv #31812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Fine for me
Though the comparison at the link doesn't make me think venv is that great? But I guess it was written by the virtualenv people? Either way, I think we don't care about the features that are missing. Having venv bundled with Python seems like a good thing and maybe the fact it is part of the stdlib means it will be even more stable?
jeremiedbb
reviewed
Jul 22, 2025
Comment on lines
+37
to
+43
| libatlas3-base libatlas-base-dev python3-venv ccache | ||
|
|
||
| elif [[ "$DISTRIB" == "debian-32" ]]; then | ||
| apt-get update | ||
| apt-get install -y python3-dev python3-numpy python3-scipy \ | ||
| python3-matplotlib libopenblas-dev \ | ||
| python3-virtualenv python3-pandas ccache git | ||
| python3-venv python3-pandas ccache git |
There was a problem hiding this comment.
do we need to install a specific package if it's part of the standard lib ?
There was a problem hiding this comment.
Yes, because Debian packaging decides that venv is packaged separately in python3-venv ...
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this was historically used because of Python 2 support (
venvis Python 3.3+)? A more detailed comparison here.