Skip to content

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jul 22, 2025

rhs needs to be without quotes for bash regex to actually work (quoted and unquoted works in zsh 🤷).

bash-5.3$ package_version=3.4; if [[ $package_version =~ "^[.0-9]+$" ]]; then echo yes; fi
bash-5.3$ package_version=3.4; if [[ $package_version =~ ^[.0-9]+$ ]]; then echo yes; fi
yes

The impact was that the check to make sure that dev packages were used in scipy-dev was actually not checking anything.

The check seems to work in the CI build log 1

Footnotes

  1. scipy-dev is currently broken on main for a different reason

Copy link

github-actions bot commented Jul 22, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 821fcd6. Link to the linter CI: here

@lesteve lesteve changed the title CI Fix Azure install bash regex match CI Fix Azure install.sh bash regex match Jul 22, 2025
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks

@jeremiedbb jeremiedbb merged commit 5464d9a into scikit-learn:main Jul 22, 2025
38 checks passed
@lesteve lesteve deleted the azure-install-regex-fix branch July 22, 2025 12:44
lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Aug 22, 2025
@jeremiedbb jeremiedbb mentioned this pull request Sep 3, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants