Add Windows ARM64 GHA runner #31867
Add Windows ARM64 GHA runner #31867
Conversation
347124c to
f6d4929
Compare
Fixes issue : scikit-learn#30567
f6d4929 to
721947f
Compare
|
@vask2108 please never force push here. It makes reviews harder, and we squash and merge anyway. This can be put as a draft PR since I don't think we should really look at it much until our dependencies have all the wheels available first. |
|
@adrinjalali As it was cosmetic change, I did a the force push. But I can understand the inconvenience, I will definitely avoid next time. What I understand from your response is that, you would like to wait for SciPy (dependency) wheel to be available in PyPI to proceed further with this PR? Until then, you consider this as draft PR. I don't think any other dependency wheel is pending apart from SciPy Is my understanding is correct? Thank you. |
|
Yes, that sounds about right. |
There was a problem hiding this comment.
Thanks for the PR. I took a look at the diff and scanned the CI outputs, and it looks good to me.
But I would also rather wait for SciPy to publish a stable release with Windows ARM64 wheels to avoid having to rely on the sed-based hackish workaround in our CI config.
However, if a downstream project of scikit-learn would like to have access to nightly Windows ARM64 builds before that happens, I am fine with merging that PR earlier.
| @@ -173,6 +189,24 @@ jobs: | |||
| with: | |||
| miniforge-version: latest | |||
|
|
|||
| # PyPI not yet hosting SciPy wheel as WoA PR of SciPy recently merged. | |||
| # This workaround will be removed once PyPI hosts SciPy wheel. | |||
There was a problem hiding this comment.
| # This workaround will be removed once PyPI hosts SciPy wheel. | |
| # TODO: remove this workaround once PyPI hosts SciPy wheel. |
|
+1 for waiting for a scipy release with Windows arm wheels. According to scipy/scipy#23122 (comment) a scipy release with Windows arm wheels may happen some time in September 2025. |
Reference Issues/PRs
Fixes issue : #30567
What does this implement/fix? Explain your changes.
This PR will add CI work to create Windows on ARM64(WoA) wheel.
Any other comments?
Please note SciPy Windows on Arm64 (WoA) is recently committed and SciPy wheel will take sometime to appear in PyPI. Currently I have to create a temporary patch to pick it from pypi.anaconda.org. I will remove this temporary solution soon, once PyPI hosts SciPy wheel. Please see the comment here ( scipy/scipy#23122 (comment) )
Please also note WoA GHA runners are new (available from April 2025) and docker is not available yet. So docker is skipped for WoA now.