ENH/FIX stopping criterion for coordinate descent gap <= tol
#31906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tol <= gap instead of tol < gap
tol <= gap
OmarManzoor
approved these changes
Aug 11, 2025
virchan
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Thanks for PR, @lorentzenchr!
Just a few minor issues with the rendered docs:
Otherwise, LGTM!
We also have a few other PRs updating _coordinate_descent.py (e.g., #31882, #31909), so at some point we might need to sort out the merge order.
tol <= gapgap <= tol
|
I had missed the parameter docstring of |
This one first, please. |
|
Technically, this PR has the approval of two core contributors. @OmarManzoor wanna merge? |
OmarManzoor
reviewed
Aug 13, 2025
doc/whats_new/upcoming_changes/sklearn.linear_model/31906.enhancement.rst
Outdated
Show resolved
Hide resolved
…ncement.rst Co-authored-by: Omar Salman <omar.salman2007@gmail.com>
OmarManzoor
reviewed
Aug 13, 2025
|
LGTM. Let's enable auto-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Noted already in #20144.
What does this implement/fix? Explain your changes.
The stopping criterion in the main branch reads:
gap < tol, but a better version isgap <= tol.Any other comments?
Reduce (or explicitly suppress) many Convergence warnings in test suite, see #4780.