docs: minor typos fixed #31945
Merged
docs: minor typos fixed #31945
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Aug 16, 2025
| @@ -289,7 +289,7 @@ def test_check_array_links_to_imputer_doc_only_for_X(input_name, retype): | |||
| assert extended_msg not in ctx.value.args[0] | |||
|
|
|||
| if input_name == "X": | |||
| # Veriy that _validate_data is automatically called with the right argument | |||
| # Verfiy that _validate_data is automatically called with the right argument | |||
There was a problem hiding this comment.
From the Github action:
Suggested change
| # Verfiy that _validate_data is automatically called with the right argument | |
| # Verify that _validate_data is automatically called with the right argument |
There was a problem hiding this comment.
Hey @thomasjpfan, updated the PR now. Should be good to go
betatim
approved these changes
Aug 20, 2025
|
@maitreytalware while you are at it can you do the PyPi => PyPI replacement in line 3 of the README? Note: it seems like rst doesn't care about the inconsistency since the PyPI badge is still shown, or maybe GitHub does the right thing not sure ... Edit: Apparently from the rst doc for substitutions:
|
|
@lesteve, the PR was merged yesterday. I can add it as todo for my next PR or we can make issue |
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Aug 22, 2025
Co-authored-by: Work <Work@Maitreys-MacBook-Pro.local>
|
Yes I know. I was suggesting you open a new PR to fix it if you feel like it 🙏! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor typos fixed