Skip to content

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Partially solves solves #229.
Continuation of #31882 (which should be merged first!!!)

What does this implement/fix? Explain your changes.

Gap safe screening rules for the Cython funtion sparse_enet_coordinate_descent.

Any other comments?

A bit of refactoring for redundant code.

Copy link

github-actions bot commented Aug 21, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: f8c6736. Link to the linter CI: here

@lorentzenchr lorentzenchr changed the title Gap safe 2 sparse ENH add gap safe screening rules tosparse_ enet_coordinate_descent Aug 21, 2025
@lorentzenchr lorentzenchr changed the title ENH add gap safe screening rules tosparse_ enet_coordinate_descent ENH add gap safe screening rules to sparse_ enet_coordinate_descent Aug 21, 2025
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lorentzenchr

@OmarManzoor OmarManzoor added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cython module:linear_model Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants