Skip to content

Conversation

lucascolley
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 570a679. Link to the linter CI: here

@lucascolley lucascolley marked this pull request as ready for review August 22, 2025 12:44
@github-actions github-actions bot removed the CUDA CI label Aug 22, 2025
@lucascolley
Copy link
Contributor Author

ready to go 👍

Copy link
Member

@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @lucascolley!

Maybe I'll ping @lucyleeow and @OmarManzoor to see if they have anything to weigh in on before merging.

@lucascolley
Copy link
Contributor Author

for some context, this is preparation for a further bump once we have data-apis/array-api-extra#398 merged. Then we can replace all uses of np.nan_to_num in sklearn, which was initially discussed at #30637. FYI @StefanieSenger !

@lesteve lesteve merged commit f2cd677 into scikit-learn:main Aug 25, 2025
47 checks passed
@lesteve
Copy link
Member

lesteve commented Aug 25, 2025

Merging this one, thanks!

@lucascolley lucascolley deleted the xpx-0.8.0 branch August 25, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants