[WIP] Add svdd implementation #3201
Conversation
|
Thanks! This looks interesting, but requires tests. I'm marking it as a WIP (work in progress) pending the addition of tests and documentation. |
|
In terms of documentation, I assume this should be discussed under Outlier Detection, and be included in The class docstring should refer to the Tax and Duin paper. |
|
I've added some tests and documentation. I hope it's Ok. Please say what should be added and changed. |
doc/modules/svm.rst
Outdated
| ---- | ||
|
|
||
| Given vectors :math:`x_1, \cdots, x_l`, :class:`SVDD` build the smallest sphere | ||
| around them. Solvng the problem: |
|
Ok, typos are fixed. Anything else? |
|
There are some conflicts with new version. What is the right way to deal with them? Take new version of sklean and modify it or there is more elegant way? |
| SVDD | ||
| ---- | ||
|
|
||
| Given vectors :math:`x_1, \cdots, x_l`, :class:`SVDD` build the smallest sphere |
There was a problem hiding this comment.
Less maths and more intuition please: why is this useful? Why is it more/differently useful than a standard SVM? What's the intuition behind it.
We also need a figure, generated from the example (don't check the generated figure in the git, use the fact that it is automatically generated by 'make html').
|
To merge you can either do a 'git merge master' after updating master, and then resolve conflicts manually, or reapply the changes. Given that there are fairly beeffy changes to the core libSVM organization, it might be worth reapplying the changes. |
|
As per @albertcthomas comment I am closing this pull request as it is superseded by #7910. Thanks for your work @sklef. |
Added realization of support vector data description from http://www.csie.ntu.edu.tw/~cjlin/libsvmtools/