MNT carry out deprecation for 1.8 of multi_class in LogisticRegression and LogisticRegressionCV #32073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremiedbb This is a very difficult to carry out deprecation. At least, this PR is a big jump start. I might not be able to finish it in time. In that case, someone can take over. |
This comment was marked as resolved.
This comment was marked as resolved.
c248ea7 to
e538ff5
Compare
|
Dear reviewers, feel free to finish in case I am unresponsive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Carries out #28703 and #31241.
Contributes massively to #11865.
Fixes #32072What does this implement/fix? Explain your changes.
This PR removes the deprecated parameter
multi_classfromLogisticRegressionandLogisticRegressionCVand does all the necessary code refactoring to not drown of all the legacy code.Any other comments?
A lot of work, but I hope it is useful for the future.