Skip to content

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Sep 2, 2025

Now that #32023 has been merged, we can add Python 3.14 free-threaded wheels.

Copy link

github-actions bot commented Sep 2, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7c872be. Link to the linter CI: here

@lesteve lesteve marked this pull request as ready for review September 2, 2025 13:05
@lesteve
Copy link
Member Author

lesteve commented Sep 2, 2025

The CPython 3.13 free-threaded on Linux failed (see build log, I am able to reproduce with:

PYTHON_GIL=0 pytest sklearn/utils/tests/test_parallel.py -k warnings_threading --parallel-threads 4 --iterations 100

I fixed it in my last commit 7c872be (#32079).

This was probably introduced by #32023, since I locally tested a lot more with Python 3.14 free-threaded than Python 3.13 free-threaded ...

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is green.

@ogrisel ogrisel merged commit b138521 into scikit-learn:main Sep 2, 2025
73 of 74 checks passed
@lesteve lesteve deleted the py314t-wheels branch September 3, 2025 04:53
@lesteve lesteve mentioned this pull request Sep 3, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants