-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
DOC fix whatsnew entries for 1.8 #32081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's a net improvement. Here are some suggestions for further improvements:
doc/whats_new/upcoming_changes/sklearn.utils/31873.enhancement.rst
Outdated
Show resolved
Hide resolved
@lorentzenchr to avoid conflicts with #32084, you may want to revert the changes you did to |
I pushed a few more fixes and enabled auto-merge, thanks! One of them is someone seems to be doing to much C++ and not enough Python 😉. I think there are still a few minor issues but they can always be fixed in a further PR ... |
See title.