Skip to content

Conversation

lorentzenchr
Copy link
Member

See title.

Copy link

github-actions bot commented Sep 2, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 333318c. Link to the linter CI: here

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's a net improvement. Here are some suggestions for further improvements:

@lesteve
Copy link
Member

lesteve commented Sep 3, 2025

@lorentzenchr to avoid conflicts with #32084, you may want to revert the changes you did to doc/whats_new/upcoming_changes/array-api/29822.enhancement.rst

@lesteve
Copy link
Member

lesteve commented Sep 4, 2025

I pushed a few more fixes and enabled auto-merge, thanks! One of them is someone seems to be doing to much C++ and not enough Python 😉.

I think there are still a few minor issues but they can always be fixed in a further PR ...

@lesteve lesteve enabled auto-merge (squash) September 4, 2025 07:54
@lesteve lesteve merged commit f72958d into scikit-learn:main Sep 4, 2025
36 checks passed
@lorentzenchr lorentzenchr deleted the cln_whatsnew_1_8 branch September 4, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants