Skip to content

[WIP] Sparse and Multioutput LabelEncoder #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Sparse and Multioutput LabelEncoder #3592

wants to merge 2 commits into from

Conversation

hamsal
Copy link
Contributor

@hamsal hamsal commented Aug 26, 2014

  • sparse and multioutput fit
  • sparse and multioutput transform
  • sparse and multioutput fit_transform
  • sparse and multioutput inverse_transform
  • Maintain ValueError on unseen labels
  • test for multioutput
  • test for sparse formats

@arjoly
Copy link
Member

arjoly commented Aug 26, 2014

Thanks @hamsal !!!

@hamsal hamsal changed the title Sparse and Multioutput LabelEncoder [WIP] Sparse and Multioutput LabelEncoder Aug 26, 2014
@hamsal hamsal mentioned this pull request Aug 26, 2014
3 tasks
@jnothman
Copy link
Member

At this juncture, I would like to confirm that we think sparse multioutput data is a common enough occurrence to use sparse matrices for its representation. Until #3350, I had assumed we were only interested in sparse representation of multilabel data, where spareness is common.

@arjoly
Copy link
Member

arjoly commented Aug 26, 2014

@jnothman Do you suggest supporting sparse multilabel data and dense multioutput multiclass, but not sparse multioutput multiclass?

@hamsal
Copy link
Contributor Author

hamsal commented Aug 27, 2014

I think jnothman is for supporting sparse multioutput multiclass since he suggested that sparse label encoding code from the knn PR be implemented here

@jnothman
Copy link
Member

That was a conditional support: we should definitely support multioutput
LabelEncoder rather than inventing that wheel in multiple places; and if we
want support for sparse multioutput, then it should be supported by
LabelEncoder too. Whether we need support for sparse multioutput data is a
matter of finding datasets that match this expectation.

On 27 August 2014 10:49, hamsal notifications@github.com wrote:

I think jnothman is for supporting sparse multioutput multiclass since
he suggested that sparse label encoding code from the knn PR be implemented
here


Reply to this email directly or view it on GitHub
#3592 (comment)
.

@mjbommar
Copy link
Contributor

If there's any desire to complete #3483 (#3243), someone should adopt #3483
before this. I will definitely need to abandon them if this work is merged
first.

Thanks,
Michael J. Bommarito II, CEO
Bommarito Consulting, LLC
Web: http://www.bommaritollc.com
Mobile: +1 (646) 450-3387

On Tue, Aug 26, 2014 at 9:58 PM, jnothman notifications@github.com wrote:

That was a conditional support: we should definitely support multioutput
LabelEncoder rather than inventing that wheel in multiple places; and if
we
want support for sparse multioutput, then it should be supported by
LabelEncoder too. Whether we need support for sparse multioutput data is a
matter of finding datasets that match this expectation.

On 27 August 2014 10:49, hamsal notifications@github.com wrote:

I think jnothman is for supporting sparse multioutput multiclass since
he suggested that sparse label encoding code from the knn PR be
implemented
here


Reply to this email directly or view it on GitHub
<
https://github.com/scikit-learn/scikit-learn/pull/3592#issuecomment-53513685>

.


Reply to this email directly or view it on GitHub
#3592 (comment)
.

@hamsal
Copy link
Contributor Author

hamsal commented Aug 28, 2014

@mjbommar I can finish your work, I will do it here #3599

@mjbommar
Copy link
Contributor

Thanks!

Thanks,
Michael J. Bommarito II, CEO
Bommarito Consulting, LLC
Web: http://www.bommaritollc.com
Mobile: +1 (646) 450-3387

On Thu, Aug 28, 2014 at 1:11 PM, hamsal notifications@github.com wrote:

@mjbommar https://github.com/mjbommar I can finish your work, I will do
it here #3599 #3599


Reply to this email directly or view it on GitHub
#3592 (comment)
.

@amueller
Copy link
Member

This is implemented in OneHotEncoder afaik. If not, please open an issue describing the use-case.

@amueller amueller closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants