MRG Allow list of strings for type_filter in all_estimators. #3934
Conversation
| type_filter = [type_filter] | ||
| else: | ||
| # copy the list | ||
| type_filter = [x for x in type_filter] |
There was a problem hiding this comment.
type_filter = list(type_filter) # copy
-1 LOC :)
a56e536 to
f35116a
Compare
|
done |
MRG Allow list of strings for type_filter in all_estimators.
|
@amueller Is there a test for |
|
@ragv that would be very welcome. I'm not sure how to test completeness (except by listing all estimators, which would a bit odd). There is a test to see if the meta-estimator are filtered correctly, but I don't think all the parameters are properly tested. |
|
The test I was thinking about was this one: https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/tests/test_common.py#L62 |
|
I am thinking of moving them both along with the new tests I added to |
|
I'd say feel free to move them. |
Removes lines ;)