add dataset parameter to fetch_20newsgroups() #4035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich version of the 20ng to download ('bydate' or 'original', 'preprocessed')
|
can you run pep8 checker on your file. also see why travis is failing. |
|
Please avoid using tabs for indentation. This seems to be the cause of the test failure in Py3k |
|
I'm going to close this as with the addition of the openml fetcher #11419 adding new datasets should consist in uploading them to OpenML. In this particular case, the sparse arff parser is pretty slow, but it could be an occasion to improve that. In any case, adding new functionality to existing dataset fetchers will will be more difficult to maintain. Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some literature papers use different versions of the 20ng dataset, this parameter will allow users choose which version of the 20ng dataset to download:
@ http://people.csail.mit.edu/jrennie/20Newsgroups/20news-bydate.tar.gz
@ http://people.csail.mit.edu/jrennie/20Newsgroups/20news-19997.tar.gz
@ http://people.csail.mit.edu/jrennie/20Newsgroups/20news-18828.tar.gz