[MRG] Explain why we are somewhat selective, lower citiation rule of thumb #4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Code is maintenance cost, and we need to balance the amount of | ||
| code we have with the size of the team (and add to this the fact that | ||
| complexity scales non linearly with the number of features). | ||
| The package relies of core developers using their free time to |
5cdd809 to
8e3eea8
Compare
|
+1 For merge. |
|
LGTM, thanks @amueller. Merging. |
jnothman
added a commit
that referenced
this pull request
Jan 26, 2015
[MRG] Explain why we are somewhat selective, lower citiation rule of thumb
|
@GaelVaroquaux Feel free to add more to it and push to master, or ping me. I just didn't want to change the "inclusion criterion" without consent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I lowered the 1000+ citations to 200+ citations (I think suggested by @mblondel), and tried to add an explanation and link to the discussion about why we are selective.