[MRG+2] add validation for non-empty input data #4214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a plan :) |
| check_is_fitted) | ||
| NotFittedError, | ||
| has_fit_parameter, | ||
| check_is_fitted) |
There was a problem hiding this comment.
I agree. I did not intend to change those import lines as part of this PR but apparently my editor fixed the indenting without asking me :)
|
LGTM. |
|
This needs a common test, right? |
Yes I started adding some in edcd079 although I think the content of this PR only is already an improvement in its current state. Let me first rebase it on master. |
388c844 to
d16e9ee
Compare
|
I added the failing common tests in a separate PR at #4245. |
|
LGTM +1 for merge |
agramfort
added a commit
that referenced
this pull request
Feb 14, 2015
[MRG+2] add validation for non-empty input data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the discussion in #4206. This makes
check_arrayandcheck_X_yreject input arrays with less than 1 samples and less than 1 feature for 2D inputs while providing informative error message to the caller.FYI I also have implemented some common checks based on this PR in edcd079 but this reveals some missing input validation in several estimators. Those missing validation checks should better be added once @amueller's own #4136 is merged in master to avoid conflict resolution pain and redundant work.