Added missing space to exception message #4308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and corrected message. Updated tests.
|
Thanks... I have fixed this in https://github.com/scikit-learn/scikit-learn/pull/4087/files#diff-1190a10b67dd12abc6c869b9ba329f8aR90 but I guess I haven't pushed that PR towards merge of late. |
|
LGTM. Thanks. |
jnothman
added a commit
that referenced
this pull request
Mar 1, 2015
Added missing space to exception message
|
Thanks Joe! Sorry about the overlap with #4087 It would have been fine to just close this pr, BTW. |
|
You're not to have foreseen the overlap! #4087 may not be merged for a while yet, and needs a rebase in any case, so no harm done by fixing the error now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a
ValueErrorbeing raised on line 82 ofsklearn/metrics/cluster/unsupervised.pythat had a missing space.I went to fix it and realized the error message was actually incorrect (the test was that
2 <= n_labelsbut the error message said the number of labels had to be more than 2).So I improved the error message (IMO, at least) and I simplified the test, from
if not 2 <= n_labels <= n_samples-1toif not 1 < n_labels < n_sampleswhich feels cleaner to me.I also updated the two tests of the error message. Note that the error text is a regex so regex metacharacters (
.and(and)) are backslash quoted.