Skip to content

[WIP] Earth (MARS), continuation #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed

Conversation

mehdidc
Copy link
Contributor

@mehdidc mehdidc commented Mar 4, 2015

Continuation Of #2285 here.

jcrudy and others added 25 commits June 13, 2013 10:15
Getting recent changes from scikit-learn people.
I thought they were working before.  Maybe I ran the wrong tests or
something.
1. Added allow_linear argument
2. Fixed a bug in the way endspan argument was processed
3. Fixed a bug in the way sample_weights were being applied
4. Added simple test case for 3 (test needs to be improved, may be
platform dependent)
5. Fixed a typo where min_search_points was accidentally
min_searh_points
learning that is most commonly used for feature extraction and selection. ``EarthRegressor`` models can be thought of as linear models in a higher dimensional
basis space. ``EarthRegressor`` automatically searches for interactions and non-linear relationships. Each term in an ``EarthRegressor`` model is a
product of so called "hinge functions". A hinge function is a function that's equal to its argument where that argument
is greater than zero and is zero everywhere else.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure lines are less than 80c everywhere even in the docstring / doc

@agramfort
Copy link
Member

have a look at travis failure

@rth
Copy link
Member

rth commented Apr 21, 2018

Closing given that PyEarth is in sklearn-contrib; that this PR hasn't been updated in 2 3 years (unlike the pyearth repo) and that there are no open issues about this in PyEarth. Please re-open if I missed something.

@rth rth closed this Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants