Skip to content

[MRG+1] DOC/TST docstring --> comment #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

raghavrv
Copy link
Member

Following #4432

Ping @arjoly @pprett

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9300848 on ragv:travis_ignore_docstring into f46cd25 on scikit-learn:master.

@arjoly
Copy link
Member

arjoly commented Mar 26, 2015

No strong opinion on this. This is purely cosmetic.

@raghavrv
Copy link
Member Author

@arjoly This docstring --> comment conversion for test functions was done since in the verbose mode (nosetests -v test_*.py) travis prints the docstrings instead of something like this :

sklearn.tests.test_naive_bayes.test_discretenb_partial_fit() ... ok

which would be more useful I presume :)

@arjoly
Copy link
Member

arjoly commented Mar 26, 2015

ok then lgtm

@raghavrv raghavrv changed the title DOC/TST docstring --> comment [MRG+1] DOC/TST docstring --> comment Mar 26, 2015
amueller added a commit that referenced this pull request Mar 26, 2015
[MRG+1] DOC/TST docstring --> comment
@amueller amueller merged commit 73c0283 into scikit-learn:master Mar 26, 2015
@raghavrv raghavrv deleted the travis_ignore_docstring branch February 11, 2016 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants