Skip to content

TSNE in t_sne.py Replaced nan with 0 in distance matrix. Issue #4475 #4492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TSNE in t_sne.py Replaced nan with 0 in distance matrix. Issue #4475 #4492

wants to merge 1 commit into from

Conversation

timvg80
Copy link

@timvg80 timvg80 commented Apr 2, 2015

Following the suggestion by @amueller, all nan in the distance matrix have been replaced by zeros. New tests have shown this to work.

Fixed together with @daveudaimon

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling bdc4f96 on timvg80:4475 into 6e54079 on scikit-learn:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) to 95.11% when pulling bdc4f96 on timvg80:4475 into 6e54079 on scikit-learn:master.

@amueller
Copy link
Member

amueller commented Apr 2, 2015

This is not the right place to fix this, as it is not specific to t-SNE. A better fix is in #4495.

@jnothman
Copy link
Member

Is this still relevant after #9032?

@jnothman jnothman closed this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timvg80 @landscape-bot @coveralls @amueller @jnothman