[MRG + 1] ENH: preprocess: adding a max-normalization option #4695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs tests and doc updates.
|
Ah, older scipy versions don't have a |
|
Column-wise max? I guess why not. I think you should use |
|
Thanks! Travis is happy now. |
| _, norms = min_max_axis(X, 1) | ||
| norms = norms.repeat(np.diff(X.indptr)) | ||
| mask = norms != 0 | ||
| X.data[mask] /= norms[mask] |
There was a problem hiding this comment.
I feel like we should raise a ValueError "else". If you could add that and add a test, it would be much appreciated.
There was a problem hiding this comment.
Never mind, missed the check above.
|
lgtm. |
|
LGTM. Merging. Thanks! |
GaelVaroquaux
added a commit
that referenced
this pull request
May 11, 2015
[MRG + 1] ENH: preprocess: adding a max-normalization option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that max-normalization is about as common as l1 or l2 normalization in my work, so I added that option to the
preprocessing.normalize()function.