Skip to content

[MRG+2] use astype to avoid unnecessary copy #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2015
Merged

[MRG+2] use astype to avoid unnecessary copy #4754

merged 1 commit into from
May 21, 2015

Conversation

TomDLT
Copy link
Member

@TomDLT TomDLT commented May 21, 2015

use astype to avoid unnecessary copy

Additional to PR #4645 for issue #4573

@ogrisel
Copy link
Member

ogrisel commented May 21, 2015

LGTM.

@ogrisel ogrisel changed the title [MRG] use astype to avoid unnecessary copy [MRG+1] use astype to avoid unnecessary copy May 21, 2015
@arjoly
Copy link
Member

arjoly commented May 21, 2015

LGTM

@arjoly arjoly changed the title [MRG+1] use astype to avoid unnecessary copy [MRG+2] use astype to avoid unnecessary copy May 21, 2015
ogrisel added a commit that referenced this pull request May 21, 2015
@ogrisel
Merge pull request #4754 from TomDLT/astype_fix
d53634f 
[MRG+2] use astype to avoid unnecessary copy
@ogrisel ogrisel merged commit d53634f into scikit-learn:master May 21, 2015
bnaul pushed a commit to bnaul/scikit-learn that referenced this pull request May 29, 2015
@ogrisel @bnaul
Merge pull request scikit-learn#4754 from TomDLT/astype_fix
8c9052e 
[MRG+2] use astype to avoid unnecessary copy
@TomDLT TomDLT deleted the astype_fix branch September 15, 2015 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomDLT @ogrisel @arjoly