Skip to content

[MRG] DOC updated whatsnew for joblib 0.9.0b2 #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jul 13, 2015

for #4905.

@ogrisel
Copy link
Member Author

ogrisel commented Jul 13, 2015

@lesteve @vene @amueller if you have any comments on the wording of this what's new entry.

@vene
Copy link
Member

vene commented Jul 13, 2015

This can also speed up grid search on small data, which may or may not impact more users than the multilabel OvR usecase. Do you think it's worth mentioning?

@lesteve
Copy link
Member

lesteve commented Jul 13, 2015

Looks good to me. I am guessing we don't want to use a joblib beta version eventually so we should try to remember to update the whatsnew accordingly.

@vene
Copy link
Member

vene commented Jul 13, 2015

I think the idea is to have the scikit-learn master roll for a bit with the joblib beta version, to see if any issues are reported by the users who tinker with scikit-learn master. I like this plan, I think it's the best way to beta-test joblib. We could ping the statsmodels folks or other packages we know of that make use of joblib as well.

@larsmans
Copy link
Member

I just broke the merge by editing what's new. Please rebase.

@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2015

I am on it.

@ogrisel ogrisel force-pushed the doc-whatsnew-joblib-0.9.0b2 branch from bf33d77 to eca4201 Compare July 17, 2015 08:28
@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2015

@vene I took your remark into account.

@ogrisel
Copy link
Member Author

ogrisel commented Jul 17, 2015

@lesteve I agree that we should maintain the whats_new.rst updated if we upgrade again joblib before the 0.17 scikit-learn release.

@GaelVaroquaux
Copy link
Member

LGTM

Merging: this doesn't need a second 👍

GaelVaroquaux added a commit that referenced this pull request Jul 18, 2015
[MRG] DOC updated whatsnew for joblib 0.9.0b2
@GaelVaroquaux GaelVaroquaux merged commit 2f81103 into scikit-learn:master Jul 18, 2015
@amueller
Copy link
Member

thanks guys (sorry I'm still travelling)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants