Skip to content

[WIP] Gradient Boosting speed improvement #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[WIP] Gradient Boosting speed improvement #5007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bda486d
Generated C file
Jul 16, 2015
8b6844a
Merge branch 'master' of https://github.com/scikit-learn/scikit-learn
Jul 21, 2015
13ba1b1
Introduce FriedmanMSESplitter as SpeedSplitter, a faster way to do Gr…
Jul 8, 2015
760ffa4
Decision tree nosetests work now, memory issue fixed
Jul 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sklearn/ensemble/gradient_boosting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

from ..tree.tree import DecisionTreeRegressor
from ..tree._tree import DTYPE, TREE_LEAF
from ..tree._tree import PresortBestSplitter
from ..tree._tree import PresortBestSplitter, FriedmanMSESplitter
from ..tree._tree import FriedmanMSE

from ._gradient_boosting import predict_stages
Expand Down Expand Up @@ -1011,11 +1011,11 @@ def _fit_stages(self, X, y, y_pred, sample_weight, random_state,

# init criterion and splitter
criterion = FriedmanMSE(1)
splitter = PresortBestSplitter(criterion,
self.max_features_,
self.min_samples_leaf,
min_weight_leaf,
random_state)
splitter = FriedmanMSESplitter(criterion,
self.max_features_,
self.min_samples_leaf,
min_weight_leaf,
random_state)

if self.verbose:
verbose_reporter = VerboseReporter(self.verbose)
Expand Down
Loading