Skip to content

Updated code example #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ubieting
Copy link

@ubieting ubieting commented Jul 31, 2015

@ubieting ubieting closed this Jul 31, 2015
@ubieting ubieting reopened this Jul 31, 2015
@ubieting
Copy link
Author

AppVeyor and Travis failed on python 3.4, but it passed in my python34 environment. Any suggestion on what might be wrong or what to check?

@amueller
Copy link
Member

The test failures are caused by #5045 and only visible on scipy 0.16. Don't worry about them.

@amueller
Copy link
Member

You could have just pushed again into #4964 by the way.

>>> y_true_categorical = np.array(["spam", "ham", "ham", "spam", "ham", "spam"])
>>> y_prob = np.array([0.1, 0.9, 0.8, 0.3, 0.5, 0.7])
>>> brier_score_loss(y_true, y_prob)
0.14833333333333332
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably use ellipsis instead of all the digits.

@lazarillo
Copy link

This says that it is still an open issue. I was going to work on it, but I cannot see any actual problem:

  1. there are no "exceedingly long" numbers, ellipses have been used instead,

  2. the test failures have been flagged as not a real issue.

@GaelVaroquaux
Copy link
Member

The tests are failing in this PR.

I have restarted travis to get an update on the status (as that was a long time ago), but we cannot merge a PR with failing test. That's for sure a problem.

@GaelVaroquaux
Copy link
Member

OK, based on the travis error, the pull request needs to be rebased on master.

@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Oct 25, 2016
@amueller
Copy link
Member

fixed in #6841

@amueller amueller closed this Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants