[MRG] Hotfix for _criterion.pyx #5305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks @jmschrei |
| @@ -458,7 +458,7 @@ cdef class ClassificationCriterion(Criterion): | |||
| self.weighted_n_left -= w | |||
|
|
|||
| # Upate right part statistics | |||
|
Apart from my comments, LGTM as well. |
|
There are actual tests to make sure the impurity improvement calculation is correct. Those tests failed before the patch. |
5687385 to
798aeaf
Compare
|
Typo fixed. Should be good to go. |
|
LGTM. Let's wait for build bots to finish and merge |
|
+1 for adding tests to check the correctness of the impurity values wrt to hand-computed values, i'll add that to list of tasks in #5212. |
|
Merging, thanks for the hotfix @jmschrei |
glouppe
added a commit
that referenced
this pull request
Sep 23, 2015
[MRG] Hotfix for _criterion.pyx
|
thanks guys for the quick fix
|
|
thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally included a few variable name errors in the last round of review for #5278 because I did not recompile it before running unit tests. This is a patch to fix solely those issues, as noticed also in #5304.
@agramfort @GaelVaroquaux @glouppe @arjoly