[MRG + 1] Add how lda's LDA differs from sckit-learn's LDA #5553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you be a bit more explicit on the fact that scikit-learn also has an LDA. The second sentence should be something like "scikit-learn has a Latent Dirichlet Allocation. It differs from packages... because..." |
|
Will the |
|
yeah it should. lgtm. thanks :) |
|
@ariddell Could you update master and push please? |
raghavrv
suggested changes
Dec 26, 2016
| - `lda <https://github.com/ariddell/lda/>`_: Fast implementation of Latent | ||
| Dirichlet Allocation in Cython. | ||
| - `lda <https://github.com/ariddell/lda/>`_: Fast implementation of latent | ||
| Dirichlet allocation in Cython using Gibbs sampling. Whereas scikit-learn's |
raghavrv
suggested changes
Dec 26, 2016
| - `lda <https://github.com/ariddell/lda/>`_: Fast implementation of Latent | ||
| Dirichlet Allocation in Cython. | ||
| - `lda <https://github.com/ariddell/lda/>`_: Fast implementation of latent | ||
| Dirichlet allocation in Cython using Gibbs sampling. Whereas scikit-learn's |
There was a problem hiding this comment.
Actually could you restructure as -
- `lda <https://github.com/ariddell/lda/>`_: Fast implementation of latent
Dirichlet allocation in Cython which uses `Gibbs sampling
<https://en.wikipedia.org/wiki/Gibbs_sampling>`_ to sample from the true
posterior distribution. (scikit-learn's :class:`sklearn.decomposition.LatentDirichletAllocation` implementation uses
`variational inference <https://en.wikipedia.org/wiki/Variational_Bayesian_methods>`_ to sample from
a tractable approximation of a topic model's posterior distribution.)
|
Restructured as suggested. |
|
LGTM |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5529