[MRG+1]FIX serialization bug in the implementation of the pickle protocol #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65893be to
d53772d
Compare
| @@ -622,6 +624,8 @@ cdef class Tree: | |||
|
|
|||
| def __setstate__(self, d): | |||
| """Setstate re-implementation, for unpickling.""" | |||
| self.capacity = d["capacity"] | |||
There was a problem hiding this comment.
This is overridden below (line 648 in this version of the file). Shall we really have it in the state?
There was a problem hiding this comment.
I would say yes, it's documented in the class attribute.
There was a problem hiding this comment.
it's better to infer those.
|
+1 for merge except for my comment, though it does no harm to add |
|
Yes it works, thanks :) ! +1 for merge. |
agramfort
added a commit
that referenced
this pull request
Oct 23, 2015
[MRG+1]FIX serialization bug in the implementation of the pickle protocol
|
great ! |
|
Seems I arrived too late to the party on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @glouppe @amueller @jmschrei @jnothman
@ngoix this should solve your bug in the isolation forest pull request.