[MRG+1] FIX increase tolerance of class weight check for OS X #5626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually my bad: I now remember that I was running them only on 0.17.X branch on monday on this laptop. This test did not exist on that branch hence the lack of failure at that time. |
|
@TomDLT you might want to have a look. |
|
For the record, the failing test is new in #5008, merged only 8 days ago, |
|
Second review for this quick fix? @amueller @GaelVaroquaux ? |
|
I haven't read all #5008, but why do we need to decrease tolerance? |
|
@giorgiop because it doesn't pass on os X. |
amueller
added a commit
that referenced
this pull request
Nov 1, 2015
[MRG+1] FIX increase tolerance of class weight check for OS X
|
backported as 6f69e83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #5625.
Although I am not 100% to understand why we need to increase the tolerance here. I think this test used to pass on Monday. Will do a bisect and report back.