[MRG + 1] Fix for uneven grids in Partial Dependence Plots example #5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finished compiling docs locally. Output looks clean. |
|
I trust you ;) LGTM |
|
(and apart from trusting you, the output also looks good to me). |
|
This PR needs to be rebased on top of current master. Unfortunately I cannot test it as long as #6055 is not complete. |
|
Also the |
|
Rebased and merged as eb4bd09. Thanks for the fix. |
|
Cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
5846... Sorry #5810 - The problem was not in the code base, but the shape ofZ. The output of the example won't change, but a user can change thegrid_resolutionparam such that it exceeds the number of unique values and then the shapes become invalid.