Skip to content

MRG: Major SGD extension module refactoring #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 13, 2012
Merged

MRG: Major SGD extension module refactoring #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b7be62a
factored out weight vector class; dense SGD now uses ``WeightVector``…
pprett Feb 7, 2012
62c5420
enh: performance of WeightVector now comparable to explicit weight ve…
pprett Feb 7, 2012
a620e55
wip: sparse sgd now uses WeightVector - there are some broken tests t…
pprett Feb 7, 2012
28f9b4c
wip: still hunter sparse sgd bug
pprett Feb 7, 2012
1bf502b
fix: forgot to scale by wscale at the end of dot_sparse. All tests ar…
pprett Feb 7, 2012
d2ee677
added new sgd dataset abstraction to unify sparse and dense implement…
pprett Feb 7, 2012
cc8489b
Merge branch 'master' into sgd-refactoring
pprett Feb 7, 2012
36a4c37
major refactoring of sgd module::
pprett Feb 7, 2012
efc5bfe
use Py_ssize_t where appropriate; cosmit
pprett Feb 8, 2012
4017ade
Merge remote branch 'upstream/master' into sgd-refactoring
pprett Feb 12, 2012
6f914f3
cosmit: better docstrings for SGD
pprett Feb 12, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sklearn/linear_model/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ def configuration(parent_package='', top_path=None):
sources=['sgd_fast.c'],
include_dirs=[numpy.get_include()]
)
config.add_extension('sgd_fast_sparse',
sources=['sgd_fast_sparse.c'],
include_dirs=[numpy.get_include()]
)

# add other directories
config.add_subpackage('tests')
Expand Down
Loading