Skip to content

[MRG] BUG: handle integer inputs in LLE (fixes #6033) #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

jakevdp
Copy link
Member

@jakevdp jakevdp commented Feb 4, 2016

No description provided.

@agramfort
Copy link
Member

LGTM

@agramfort
Copy link
Member

I'll let @ogrisel merge if he's happy too ;)

@jakevdp jakevdp changed the title BUG: handle integer inputs in LLE (fixes #6033) [MRG] BUG: handle integer inputs in LLE (fixes #6033) Feb 18, 2016
@jakevdp
Copy link
Member Author

jakevdp commented Feb 18, 2016

I think this can be merged.

@JTchaoren
Copy link

JTchaoren commented May 23, 2016

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\spyderlib\widgets\externalshell\sitecustomize.py", line 699, in runfile
    execfile(filename, namespace)
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\spyderlib\widgets\externalshell\sitecustomize.py", line 74, in execfile
    exec(compile(scripttext, filename, 'exec'), glob, loc)
  File "D:/pythonana/chapter5/chapter5/demo/code/arima_test.py", line 63, in <module>
    model = ARIMA(data, (0,1,1)).fit() #建立ARIMA(0, 1, 1)模型
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\statsmodels\tsa\arima_model.py", line 1105, in fit
    callback, **kwargs)
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\statsmodels\tsa\arima_model.py", line 920, in fit
    start_params = self._fit_start_params((k_ar, k_ma, k), method)
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\statsmodels\tsa\arima_model.py", line 557, in _fit_start_params
    start_params = self._fit_start_params_hr(order)
  File "C:\Users\JTSuperman\Anaconda2\lib\site-packages\statsmodels\tsa\arima_model.py", line 493, in _fit_start_params_hr
    endog -= np.dot(exog, ols_params).squeeze()
TypeError: Cannot cast ufunc subtract output from dtype('float64') to dtype('int64') with casting rule 'same_kind'
>>> 

help me ,my same ,how to solve it,

@jakevdp
Copy link
Member Author

jakevdp commented May 23, 2016

@JTchaoren – it looks like you're using Statsmodels. You might try asking your question on the forums for that project.

@JTchaoren
Copy link

OK! Did you meet the same question?

@jakevdp
Copy link
Member Author

jakevdp commented May 23, 2016

No, I've not used statsmodels much at all.

@amueller amueller merged commit c948319 into scikit-learn:master Oct 7, 2016
@amueller
Copy link
Member

amueller commented Oct 7, 2016

LGTM thanks

@jnothman
Copy link
Member

jnothman commented Oct 8, 2016

does this need a what's new?

On 8 October 2016 at 09:56, Andreas Mueller notifications@github.com
wrote:

LGTM thanks


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6282 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz67i9CqgXVSZSFtCHshNcCdhbC4p9ks5qxs4KgaJpZM4HT2me
.

@amueller
Copy link
Member

amueller commented Oct 8, 2016

Why not. @jakevdp do you want to push a whatsnew to master?

jakevdp added a commit to jakevdp/scikit-learn that referenced this pull request Oct 10, 2016
@jakevdp
Copy link
Member Author

jakevdp commented Oct 10, 2016

Done in #7629

GaelVaroquaux pushed a commit that referenced this pull request Oct 10, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Oct 14, 2016
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Nov 9, 2016
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
* tag '0.18.1': (144 commits)
  skip tree-test on 32bit
  do the warning test as we do it in other places.
  Replase assert_equal by assert_almost_equal in cosine test
  version bump 0.18.1
  fix merge conflict mess in whatsnew
  add the python2.6 warning to 0.18.1
  fix learning_curve test that I messed up in cherry-picking the "reentrant cv" PR.
  sync whatsnew with master
  [MRG] TST Ensure __dict__ is unmodified by predict, transform, etc (scikit-learn#7553)
  FIX scikit-learn#6420: Cloning decision tree estimators breaks criterion objects (scikit-learn#7680)
  Add whats new entry for scikit-learn#6282 (scikit-learn#7629)
  [MGR + 2] fix selectFdr bug (scikit-learn#7490)
  fixed whatsnew cherry-pick mess (somewhat)
  [MRG + 2] FIX LogisticRegressionCV to correctly handle string labels (scikit-learn#5874)
  [MRG + 2] Fixed parameter setting in SelectFromModel (scikit-learn#7764)
  [MRG+2] DOC adding separate `fit()` methods (and docstrings) for DecisionTreeClassifier and DecisionTreeRegressor (scikit-learn#7824)
  Fix docstring typo (scikit-learn#7844) n_features --> n_components
  [MRG + 1] DOC adding :user: role to whats_new (scikit-learn#7818)
  [MRG+1] label binarizer not used consistently in CalibratedClassifierCV (scikit-learn#7799)
  DOC : fix docstring of AIC/BIC in GMM
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
* releases: (144 commits)
  skip tree-test on 32bit
  do the warning test as we do it in other places.
  Replase assert_equal by assert_almost_equal in cosine test
  version bump 0.18.1
  fix merge conflict mess in whatsnew
  add the python2.6 warning to 0.18.1
  fix learning_curve test that I messed up in cherry-picking the "reentrant cv" PR.
  sync whatsnew with master
  [MRG] TST Ensure __dict__ is unmodified by predict, transform, etc (scikit-learn#7553)
  FIX scikit-learn#6420: Cloning decision tree estimators breaks criterion objects (scikit-learn#7680)
  Add whats new entry for scikit-learn#6282 (scikit-learn#7629)
  [MGR + 2] fix selectFdr bug (scikit-learn#7490)
  fixed whatsnew cherry-pick mess (somewhat)
  [MRG + 2] FIX LogisticRegressionCV to correctly handle string labels (scikit-learn#5874)
  [MRG + 2] Fixed parameter setting in SelectFromModel (scikit-learn#7764)
  [MRG+2] DOC adding separate `fit()` methods (and docstrings) for DecisionTreeClassifier and DecisionTreeRegressor (scikit-learn#7824)
  Fix docstring typo (scikit-learn#7844) n_features --> n_components
  [MRG + 1] DOC adding :user: role to whats_new (scikit-learn#7818)
  [MRG+1] label binarizer not used consistently in CalibratedClassifierCV (scikit-learn#7799)
  DOC : fix docstring of AIC/BIC in GMM
  ...

 Conflicts:  removed
	sklearn/externals/joblib/__init__.py
	sklearn/externals/joblib/_parallel_backends.py
	sklearn/externals/joblib/testing.py
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
* dfsg: (144 commits)
  skip tree-test on 32bit
  do the warning test as we do it in other places.
  Replase assert_equal by assert_almost_equal in cosine test
  version bump 0.18.1
  fix merge conflict mess in whatsnew
  add the python2.6 warning to 0.18.1
  fix learning_curve test that I messed up in cherry-picking the "reentrant cv" PR.
  sync whatsnew with master
  [MRG] TST Ensure __dict__ is unmodified by predict, transform, etc (scikit-learn#7553)
  FIX scikit-learn#6420: Cloning decision tree estimators breaks criterion objects (scikit-learn#7680)
  Add whats new entry for scikit-learn#6282 (scikit-learn#7629)
  [MGR + 2] fix selectFdr bug (scikit-learn#7490)
  fixed whatsnew cherry-pick mess (somewhat)
  [MRG + 2] FIX LogisticRegressionCV to correctly handle string labels (scikit-learn#5874)
  [MRG + 2] Fixed parameter setting in SelectFromModel (scikit-learn#7764)
  [MRG+2] DOC adding separate `fit()` methods (and docstrings) for DecisionTreeClassifier and DecisionTreeRegressor (scikit-learn#7824)
  Fix docstring typo (scikit-learn#7844) n_features --> n_components
  [MRG + 1] DOC adding :user: role to whats_new (scikit-learn#7818)
  [MRG+1] label binarizer not used consistently in CalibratedClassifierCV (scikit-learn#7799)
  DOC : fix docstring of AIC/BIC in GMM
  ...
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants