-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
Backport 0.17.X -- FIX in randomized_svd flip sign #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 0.17.X -- FIX in randomized_svd flip sign #6375
Conversation
Flip sign according to `u` in both cases of `transpose`.
As this is a trivial cherry pick of a previously passing commit, I am not really sure what the problem is with CircleCI, but it looks like it might be running out of memory after building the documentation. FWIW, Travis CI appears to pass. |
LGTM |
Hmm...so I tried to cherry-pick that commit ( 3daab8a ), as well, but it did not apply cleanly. As I am not really sure what is going on in that code, I don't feel comfortable resolving those merge conflicts. Would someone else who knows more about it please give it a try? |
AFAIK (but I may be wrong about that), backports in maintenance branches are done directly by core contributors and not via PRs. |
No clue. I think this is the first time I have done a PR for this project. So, not sure what the rules are. Though I would assume that most people appreciate having some of their work done for them. :) In any event, I just wanted to make sure this saw its way into a bugfix release as I know it was causing me problems. |
This looks good to me. I will take care of fixing the documentation in 0.17.X. |
Backport 0.17.X -- FIX in randomized_svd flip sign
Thanks @ogrisel. |
Cherry picks the fix from this commit ( cfa498c ) in
master
. Also, see the PR ( #6135 ) this was taken from.