[MRG+1] DOC: Fix broken linkcheck #6417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,9 +279,9 @@ path environment variable. | |||
| ------------- | |||
|
|
|||
| for 32-bit python it is possible use the standalone installers for | |||
| `microsoft visual c++ express 2008 <http://go.microsoft.com/?linkid=7729279>`_ | |||
There was a problem hiding this comment.
This link still work for me, why change it?
|
Besides those 2 comments, LGTM. |
|
closed in favor of properly squashed and rebased version at #6419 |
|
Just a remark: when you squash / rebase / amend you can still push to the same PR (remote branch) with |
|
Yeah, I generally force push in my other PRs, but I just thought I made too big of a git mess in this one and that it's be easier to start over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #5968. I've rebased it on top of the current master, and will squash when this PR is approved.