[MRG+1] DOC: Fix broken links #6419
Conversation
| @@ -423,7 +423,7 @@ Daniel Weitzenfeld, Senior Data Scientist at HowAboutWe | |||
| </span> | |||
|
|
|||
|
|
|||
| `PeerIndex <http://www.peerindex.com/>`_ | |||
| `PeerIndex <https://www.brandwatch.com/peerindex-and-brandwatch>`_ | |||
| ---------------------------------------- | |||
There was a problem hiding this comment.
The lines with - sign should be updated to match the length of the text.
|
Please avoid non-descriptive commit messages like: "doc: address some comments by @ogrisel" and instead describe what is the purpose of the comment. commit messages will be read outside of the scope of any PR in the future. |
|
@ogrisel noted, I generally try to squash commits after approval to make them more descriptive. thanks for the input and review! |
6f00377 to
db716be
Compare
|
For the record, I gave my +1 on a past version of this PR. |
db716be to
7bd1551
Compare
|
I rebased onto master to solve merge conflicts, can I get one more review? @GaelVaroquaux @rvraghav93 @agramfort perhaps? |
7bd1551 to
80ef3ed
Compare
|
LGTM. Could you rebase ? |
80ef3ed to
83be3f4
Compare
83be3f4 to
9b7176d
Compare
|
Thanks for taking a look @tguillemot , I've rebased and squashed changes into @sieben's original commit. |
|
This looks good to me too. Thanks! |
|
Thanks @nelson-liu |
This is a properly squashed and rebased version of #6417. Sorry for the noise!