[MRG] don't use deprecated random_integers function, use randint instead. #6505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andint is exclusive wrt "high", so add one everywhere.
|
LGTM |
|
One of the travis failures looks like it is related to that problem with MKL/libgfortran from a week ago (can't find the issue 😢) The other one I am not sure about. Could you tickle travis and see if it passes now? |
|
restarted travis |
|
LGTM |
|
I can merge once you rebase over the fix.. |
|
Was fixed by #6712. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of the deprecated (in numpy dev)
random_integersfunction, replacing it withrandint. All the values forhighneed to be adjusted becauserandom_integersuses inclusive bounds, andrandintuses exclusive bounds.This makes the travis output on the numpy dev branch much more readable.