Skip to content

[MRG+1] Make assign_rows_csr support Cython fused types #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2016
Merged

[MRG+1] Make assign_rows_csr support Cython fused types #6588

merged 1 commit into from
Mar 25, 2016

Conversation

yenchenlin
Copy link
Contributor

This PR makes assign_rows_csr now support both np.float32 and np.float64.
May @MechCoder please review this?

@yenchenlin yenchenlin changed the title Make assign_rows_csr support Cython fused types [MRG] Make assign_rows_csr support Cython fused types Mar 24, 2016
@yenchenlin yenchenlin mentioned this pull request Mar 25, 2016
Merged
@TomDLT
Copy link
Member

TomDLT commented Mar 25, 2016

LGTM

@TomDLT TomDLT changed the title [MRG] Make assign_rows_csr support Cython fused types [MRG+1] Make assign_rows_csr support Cython fused types Mar 25, 2016
@MechCoder
Copy link
Member

LGTM. Thanks!

@MechCoder MechCoder merged commit d7cf4b0 into scikit-learn:master Mar 25, 2016
@MechCoder
Copy link
Member

It might be good to fix the csr_mean_variance_axis0 and csc_mean_variance_axis0 right now, since it is used in quite a lot of places.

The add_row_csr is used only in kmeans.

It also might be worth seeing if add_row_csr can be added into assign_rows_csr (though that is of less priority)

@yenchenlin
Copy link
Contributor Author

Okay!
Will do.

@yenchenlin yenchenlin mentioned this pull request Mar 26, 2016
Merged
@yenchenlin yenchenlin mentioned this pull request Apr 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yenchenlin @TomDLT @MechCoder