[MRG+1] Disabled randomized_svd warning when number of iterations is no… #6749
Conversation
| "achieve higher precision.") | ||
| if n_iter_specified: | ||
| warnings.warn("The number of power iterations is increased to " | ||
| "7 to achieve higher precision.") |
There was a problem hiding this comment.
style: can you please fix the indentation level?
There was a problem hiding this comment.
Sorry to be late, I will check it carefully next time
There was a problem hiding this comment.
Shouldn't that be the opposite? It should be raise when it was not specified!
There was a problem hiding this comment.
wait why are we changing n_iter here if it was explicitly given? I don't understand the logic. We should do either a good default or we should do what the user said. If the user provided n_iter we should do what she said IMHO.
|
+1 for merge. Thanks @jordisoler. |
| @@ -349,6 +349,13 @@ def randomized_svd(M, n_components, n_oversamples=10, n_iter=4, | |||
| n_random = n_components + n_oversamples | |||
| n_samples, n_features = M.shape | |||
|
|
|||
| if n_iter == None: | |||
There was a problem hiding this comment.
if n_iter is None
Even if that doesn't make such a big difference, this is the usual way of comparing against None.
There was a problem hiding this comment.
Yes! Sorry for that, and thanks
|
LGTM |
|
will fix the indent in master. thx @jordisoler |
Disabled randomized_svd warning when number of iterations is not specified (#6746)