[MRG+1] MAINT: Remove add_row_csr #6810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearing all the caches and requesting a new CI run seems to have worked. Needs another reviewer, perhaps on the old PR... |
Yeah, probably best to continue the discussion on #6676. @yenchenlin1994 can you close this PR? |
|
Sure, thanks @lesteve . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is created to solve a Travis build cache issue since PR #6676 can't pass CI.
Add_row_csris used only in 2 places.This pull request removes the usage replacing one loop by assign_rows_csr and the other by just reusing the code.