Skip to content

[MRG+1] Modification of the GaussianMixture class. #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2016
Merged

[MRG+1] Modification of the GaussianMixture class. #6824

merged 1 commit into from
Jun 2, 2016

Conversation

tguillemot
Copy link
Contributor

@tguillemot tguillemot commented May 25, 2016 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR avoid useless computation of the covariance matrix.
Moreover, these modifications are necessary for the integration of the BayesianGaussianMixture class.
#6651

@tguillemot
Modification of the GaussianMixture class.
c55b488 
Remove the useless computation of the covariance matrix.
Prepare the integration of the BayesianGaussianMixture class.
@tguillemot tguillemot changed the title Modification of the GaussianMixture class. [MRG] Modification of the GaussianMixture class. May 25, 2016
@agramfort
Copy link
Member

LGTM

@agramfort agramfort changed the title [MRG] Modification of the GaussianMixture class. [MRG+1] Modification of the GaussianMixture class. May 26, 2016
@tguillemot
Copy link
Contributor Author

Thx @agramfort .
@ogrisel @raghavrv Another review ?

@tguillemot
Copy link
Contributor Author

@ogrisel @TomDLT @raghavrv If you have some time to have a look.

@TomDLT
Copy link
Member

TomDLT commented Jun 2, 2016

The code is clearer this way, good job!

@TomDLT TomDLT merged commit e669f87 into scikit-learn:master Jun 2, 2016
@ogrisel
Copy link
Member

ogrisel commented Jun 3, 2016

Indeed good job :)

olologin pushed a commit to olologin/scikit-learn that referenced this pull request Aug 24, 2016
@tguillemot @olologin
Modification of the GaussianMixture class. (scikit-learn#6824)
d4ecb08 
Remove the useless computation of the covariance matrix.
Prepare the integration of the BayesianGaussianMixture class.
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
@tguillemot @TomDLT
Modification of the GaussianMixture class. (scikit-learn#6824)
acbde9a 
Remove the useless computation of the covariance matrix.
Prepare the integration of the BayesianGaussianMixture class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tguillemot @agramfort @TomDLT @ogrisel