Skip to content

[MRG] DOC updating changelog links on homepage #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2016
Merged

[MRG] DOC updating changelog links on homepage #6901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@
<h4>News</h4>
<ul>
<li><em>On-going development:</em>
<a href="whats_new.html"><em>What's new</em> (Changelog)</a>
<a href="/dev/whats_new.html"><em>What's new</em> (Changelog)</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be ../dev/whats_new.html.

The best way to make sure would be if you could rebase on master. The CircleCI build was fixed and we could look at the generated doc in CircleCI.

Copy link
Contributor Author

@jamoque jamoque Jun 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lesteve In this case, /dev/whats_new.html and ../dev/whats_new.html are equivalent because .. of stable/ is /

That being said, do you want me to change it to ../dev/whats_new.html anyway? I don't see an advantage, but if you do I can update.

Copy link
Member

@lesteve lesteve Jun 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right actually, /dev/whats_new.html does work, not sure how I tested this originally.

The CircleCI build looks fine (although it doesn't test the /dev/whats_new.html). +1 for merge.

</li>
<li><em>November 2015.</em> scikit-learn 0.17.0 is available for download (<a href="whats_new.html">Changelog</a>).
<li><em>November 2015.</em> scikit-learn 0.17.0 is available for download (<a href="whats_new.html#version-0-17">Changelog</a>).
</li>
<li><em>March 2015.</em> scikit-learn 0.16.0 is available for download (<a href="whats_new.html">Changelog</a>).
<li><em>March 2015.</em> scikit-learn 0.16.0 is available for download (<a href="whats_new.html#version-0-16">Changelog</a>).
</li>
<li><em>July 2014.</em> scikit-learn 0.15.0 is available for download (<a href="whats_new.html">Changelog</a>).
<li><em>July 2014.</em> scikit-learn 0.15.0 is available for download (<a href="whats_new.html#version-0-15">Changelog</a>).
</li>
<li><em>July 14-20th, 2014: international sprint.</em>
During this week-long sprint, we gathered 18 of the core
Expand All @@ -225,7 +225,7 @@
<a href="http://www.inria.fr/">Inria</a>,
and <a href="http://www.tinyclues.com/">tinyclues</a>.
</li>
<li><em>August 2013.</em> scikit-learn 0.14 is available for download (<a href="whats_new.html">Changelog</a>).
<li><em>August 2013.</em> scikit-learn 0.14 is available for download (<a href="whats_new.html#version-0-14">Changelog</a>).
</li>
</ul>
</div>
Expand Down