[MRG+2] Correct Deprecation of DPGMM and VBGMM. #7124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -309,7 +309,7 @@ def test_train_1d(self, params='wmc'): | |||
| with ignore_warnings(category=DeprecationWarning): | |||
| g.fit(X) | |||
| trainll = g.score(X) | |||
| if isinstance(g, mixture.DPGMM): | |||
There was a problem hiding this comment.
DPGMM and VBGMM are both deprecated and as VBGMM inherit from DPGMM you have two warnings messages when you call VBGMM.
I've corrected that to make sure the deprecation warning is meaningfull and moreover to be sure to pass the test once I will modify the deprecation message to refer to the new BayesianGaussianMixture class.
8 tasks
|
@amueller merge if you're happy. +1 on my side |
|
@ngoix If you have some time to review this, it's related to the Bayesian Gaussian Mixture. |
|
This looks good to me! |
|
@agramfort @ngoix Thanks. |
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation of
VBGMMis not done correctly indeed when we callVBGMMwe have two deprecation messages: one forVBGMMone forDPGMM.Consequently I have modify the code (as we have done before for the
GMMclass) to be sure that the right deprecation warning is launched.@agramfort @ogrisel @amueller Can you have a look please ?