Changed signature of CV split to accept X=None #7128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one might argue that just providing |
|
decision in #7593 was to not do this apparently, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#7126
What does this implement/fix? Explain your changes.
This allows the split methods of cross validation classes such as model_selection.StratifiedKFold
to accept None as the value of the X data parameter. The X parameter is not used in the
functions except to introspect the number of sample which can also be introspected from y (which is given and used in the supervised case).
I added the appropriate tests to cover this new behavior as well as updated the documentation appropriately.