[MRG + 1] More versionadded everywhere! #7403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +163,9 @@ class LeaveOneOut(BaseCrossValidator): | |||
| stratification of the dataset. | |||
|
|
|||
| GroupKFold: K-fold iterator variant with non-overlapping groups. | |||
|
|
|||
| .. versionchanged:: 0.18 | |||
| Moved from sklearn.cross_validation. | |||
There was a problem hiding this comment.
No. The interface is too different to just say this is a move.
|
IMO the point of these things is that if someone wants to make code that is portable back to scikit-learn 0.17, they should have guidance in the docstring which features were available. Hence "moved" on CV splitters is unhelpful; they're not backwards compatible. Annotation of private functions is also unhelpful. |
d90661f to
5698cea
Compare
|
better? |
| @@ -197,6 +197,8 @@ def decision_path(self, X): | |||
| n_nodes_ptr : array of size (n_estimators + 1, ) | |||
| The columns from indicator[n_nodes_ptr[i]:n_nodes_ptr[i+1]] | |||
| gives the indicator value for the i-th estimator. | |||
|
|
|||
| .. versionadded:: 0.18 | |||
There was a problem hiding this comment.
This should be before the Parameters section, no?
|
LGTM, +1 for merge. Thanks very much @amueller. |
|
the legwork was done by @welch :) |
|
my very first hack day PR. thanks! |
|
I don't think I realised those |
|
What's the issue with |
|
I found it: #5445 (comment) Reading about it. |
|
+10 for not releasing them ;) |
|
Needs rebase |
indicate where exception classes were moved from
956ad0c to
667fb3a
Compare
|
rebase done. |
amueller
added a commit
that referenced
this pull request
Sep 27, 2016
* insert versionadded versionchanged directives in docstrings for 0.18 indicate where exception classes were moved from * moved versionadded in the proper places
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
* insert versionadded versionchanged directives in docstrings for 0.18 indicate where exception classes were moved from * moved versionadded in the proper places
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Nov 10, 2016
* tag '0.18': (1286 commits) [MRG + 1] More versionadded everywhere! (scikit-learn#7403) minor doc fixes fix lbfgs rename (scikit-learn#7503) minor fixes to whatsnew fix scoring function table fix rebase messup DOC more what's new subdivision DOC Attempt to impose some order on What's New 0.18 no fixed width within bold REL changes for release in 0.18.X branch (scikit-learn#7414) [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325) DOC: Added Nested Cross Validation Example (scikit-learn#7111) Sync docstring and definition default argument in kneighbors (scikit-learn#7476) added contributors for 0.18, minor formatting fixes. Fix typo in whats_new.rst [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411) Addressing issue scikit-learn#7468. (scikit-learn#7472) Reorganize README clean up deprecation warning stuff in common tests [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Nov 10, 2016
* releases: (1286 commits) [MRG + 1] More versionadded everywhere! (scikit-learn#7403) minor doc fixes fix lbfgs rename (scikit-learn#7503) minor fixes to whatsnew fix scoring function table fix rebase messup DOC more what's new subdivision DOC Attempt to impose some order on What's New 0.18 no fixed width within bold REL changes for release in 0.18.X branch (scikit-learn#7414) [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325) DOC: Added Nested Cross Validation Example (scikit-learn#7111) Sync docstring and definition default argument in kneighbors (scikit-learn#7476) added contributors for 0.18, minor formatting fixes. Fix typo in whats_new.rst [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411) Addressing issue scikit-learn#7468. (scikit-learn#7472) Reorganize README clean up deprecation warning stuff in common tests [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438) ...
yarikoptic
added a commit
to yarikoptic/scikit-learn
that referenced
this pull request
Nov 10, 2016
* dfsg: (1286 commits) [MRG + 1] More versionadded everywhere! (scikit-learn#7403) minor doc fixes fix lbfgs rename (scikit-learn#7503) minor fixes to whatsnew fix scoring function table fix rebase messup DOC more what's new subdivision DOC Attempt to impose some order on What's New 0.18 no fixed width within bold REL changes for release in 0.18.X branch (scikit-learn#7414) [MRG+2] Timing and training score in GridSearchCV (scikit-learn#7325) DOC: Added Nested Cross Validation Example (scikit-learn#7111) Sync docstring and definition default argument in kneighbors (scikit-learn#7476) added contributors for 0.18, minor formatting fixes. Fix typo in whats_new.rst [MRG+2] FIX adaboost estimators not randomising correctly (scikit-learn#7411) Addressing issue scikit-learn#7468. (scikit-learn#7472) Reorganize README clean up deprecation warning stuff in common tests [MRG+1] Fix regression in silhouette_score for clusters of size 1 (scikit-learn#7438) ...
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* insert versionadded versionchanged directives in docstrings for 0.18 indicate where exception classes were moved from * moved versionadded in the proper places
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* insert versionadded versionchanged directives in docstrings for 0.18 indicate where exception classes were moved from * moved versionadded in the proper places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #5856.
I'm not entirely sure if this is the right thing to do in all cases. Opinions @ogrisel @jnothman ?